lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 27 Aug 2014 18:07:03 -0700 (PDT)
From:	David Miller <>
Subject: Re: [PATCH] ipv6: sit: Replace rcu_assign_pointer() with

From: Andreea-Cristina Bernat <>
Date: Tue, 26 Aug 2014 16:46:32 +0300

> According to RCU_INIT_POINTER()'s block comment 3.a, it can be used if
> "3.   The referenced data structure has already been exposed to readers either
> at compile time or via rcu_assign_pointer() -and-
>  a.   You have not made -any- reader-visible changes to this structure since
> then".
> This case fulfills the conditions above because between the rtnl_dereference()
> call and the rcu_assign_pointer() call there is no update of that value.
> Therefore, this patch makes the replacement.
> The following Coccinelle semantic patch was used:
> @@
> @@
> - rcu_assign_pointer
>   (...,
> (
>  rtnl_dereference(...)
> |
>  rcu_dereference_protected(...)
> ) )
> Signed-off-by: Andreea-Cristina Bernat <>

These changes are not correct.

We need the memory barrier added by rcu_assign_pointer(), which occurs
before the assignment, otherwise the RCU pointer update might be visible
before the stores that initialize the rest of the structure in question.

I'm not applying any of these patches, sorry.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists