netdev - Re: [PATCH v2 net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53FF1681.7030406@redhat.com>
Date:	Thu, 28 Aug 2014 13:46:09 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	alexander.h.duyck@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] ixgbe: flush when in xmit_more mode and under
 descriptor pressure

On 08/28/2014 08:18 AM, David Miller wrote:
> From: Daniel Borkmann <dborkman@...hat.com>
> Date: Tue, 26 Aug 2014 19:34:18 +0200
>
>> When xmit_more mode is being used and the ring is about to
>> become full or the stack has stopped the ring, enforce a tail
>> pointer write to the hw. Otherwise, we could risk a TX hang.
>>
>> Code suggested by Alexander Duyck.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
>> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
>> ---
>>   v1->v2:
>>    - Worked in Alex' feedback; in accordance w/ Alex, sending out v2
>>    - Rerun tests, looks good
>
> Applied, thanks Daniel.
>
> I'll make similar mods to igb and vhost_net soon.

Cool, at some point later, we might want to put ...

   netif_xmit_stopped(<tx_ring>) || !skb->xmit_more

... into an API perhaps, but that can likely wait right now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html