lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Aug 2014 21:26:55 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Daniel Mack <zonque@...il.com> cc: netdev@...r.kernel.org Subject: question about drivers/net/ethernet/ti/cpsw.c I wonder if the following patch: commit aa1a15e2d9199711cdcc9399fdb22544ab835a83 Author: Daniel Mack <zonque@...il.com> Date: Sat Sep 21 00:50:38 2013 +0530 introduced a race condition in drivers/net/ethernet/ti/cpsw.c. I was looking at an old version of the file (Linux 3.10), and it has clean_irq_ret: for (i = 0; i < priv->num_irqs; i++) free_irq(priv->irqs_table[i], priv); at the beginning of the cleanup code of the probe function (cpsw_probe). The above patch replaces request_irq by devm_request_irq and gets rid of the above cleanup code. But that moves the stopping of the interrupts after the following code at the end of the function: free_netdev(priv->ndev); The interrupt handler (cpsw_interrupt) does reference priv->ndev: if (netif_running(priv->ndev)) { napi_schedule(&priv->napi); return IRQ_HANDLED; } so perhaps this could be a problem. The same happens in the remove function. julia -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists