lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Aug 2014 20:25:04 -0700 (PDT) From: David Miller <davem@...emloft.net> To: hayeswang@...ltek.com Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH net-next v2] r8152: reduce the number of Tx From: Hayes Wang <hayeswang@...ltek.com> Date: Thu, 28 Aug 2014 10:24:18 +0800 > Because the Tx has the features of stopping queue and aggregation, > We don't need many tx buffers. Change the tx number from 10 to 4 > to reduce the usage of the memory. This could save 16K * 6 bytes > memory. > > Signed-off-by: Hayes Wang <hayeswang@...ltek.com> > --- > drivers/net/usb/r8152.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 33dcc97..cc64dc0 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -424,7 +424,7 @@ enum rtl_register_content { > FULL_DUP = 0x01, > }; > > -#define RTL8152_MAX_TX 10 > +#define RTL8152_MAX_TX 4 > #define RTL8152_MAX_RX 10 This driver has a loop that iterates MAX_TX times to initialize both the RX and TX buffers. So if they are not equal, it can't possibly work. Sorry, I'm not applying this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists