netdev - Re: [PATCH net-next v3] lib/rhashtable: allow user to set the minimum shifts of shrinking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140901094126.GD27933@casper.infradead.org>
Date:	Mon, 1 Sep 2014 10:41:26 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	davem@...emloft.net, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] lib/rhashtable: allow user to set the
 minimum shifts of shrinking

On 09/01/14 at 05:28pm, Ying Xue wrote:
> Do you think it's worth replacing max() macro with max_t() regarding
> above suggestion?

Yes. max_t() is what should be used in this case.

> By the way, if the replacement should do, all max() macro in the
> lib/rhashtable.c should be replaced as well.

I think the other max() usage is fine as both arguments have a type (size_t).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html