netdev - Re: [PATCH net-next v3] xfrm: remove useless hash_resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140901112944.GG6390@secunet.com>
Date:	Mon, 1 Sep 2014 13:29:44 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Ying Xue <ying.xue@...driver.com>
CC:	<davem@...emloft.net>, <christophe.gouault@...nd.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] xfrm: remove useless hash_resize_mutex locks

On Fri, Aug 29, 2014 at 05:09:07PM +0800, Ying Xue wrote:
> In xfrm_state.c, hash_resize_mutex is defined as a local variable
> and only used in xfrm_hash_resize() which is declared as a work
> handler of xfrm.state_hash_work. But when the xfrm.state_hash_work
> work is put in the global workqueue(system_wq) with schedule_work(),
> the work will be really inserted in the global workqueue if it was
> not already queued, otherwise, it is still left in the same position
> on the the global workqueue. This means the xfrm_hash_resize() work
> handler is only executed once at any time no matter how many times
> its work is scheduled, that is, xfrm_hash_resize() is not called
> concurrently at all, so hash_resize_mutex is redundant for us.
> 
> Cc: Christophe Gouault <christophe.gouault@...nd.com>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Acked-by: David S. Miller <davem@...emloft.net>

Applied to ipsec-next, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html