netdev - Re: [PATCH net-next v4] lib/rhashtable: allow user to set the minimum shifts of shrinking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140902110418.GC6778@casper.infradead.org>
Date:	Tue, 2 Sep 2014 12:04:18 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	davem@...emloft.net, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4] lib/rhashtable: allow user to set the
 minimum shifts of shrinking

On 09/02/14 at 09:28am, Ying Xue wrote:
> +	params->min_shift = max_t(size_t, params->min_shift,
> +				  (size_t)ilog2(HASH_MIN_SIZE));
> +

Sorry for being a pain here but the cast of ilog2() is not needed
and should be avoided. The whole point of max_t() is not requiring
these casts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html