netdev - Re: [E1000-devel] e1000: convert to build_skb/napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Sep 2014 17:30:59 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Florian Westphal <fw@...len.de>
Cc:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [E1000-devel] e1000: convert to build_skb/napi_gro_frags api

On Sat, 2014-08-30 at 20:28 +0200, Florian Westphal wrote:
> e1000 driver preallocates skbs, then sends them up the stack.
> 
> This series changes the rx routine to only preallocate data buffers,
> then initialize skb right before passing it up the stack.
> 
> This gives slight performance inprovements as the skb will be
> fresh in the cache once its allocated/initialized.
> 
> The default-mtu 1500 path is converted to build_skb()/netdev_alloc_frag.
> 
> Jumbo path is converted to napi_gro_frags.
> 
> Note that this has only been tested with kvms e1000 emulation.
> 

Can you re-spin the series with Sergei's suggest change for patch 7,
please?  I will await your v2 before picking up this series, thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)