lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CALnjE+pGpZdkYQrJifVQN1TxZiOvhUDZ2=oHgX=RyLGpK9-W-Q@mail.gmail.com>
Date:	Tue, 2 Sep 2014 13:20:48 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Thomas Graf <tgraf@...ronetworks.com>
Cc:	roy.qing.li@...il.com, netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [ovs-dev] [PATCH] openvswitch: distinguish between the dropped
 and consumed skb

On Tue, Sep 2, 2014 at 6:14 AM, Thomas Graf <tgraf@...ronetworks.com> wrote:
> On 09/02/14 at 08:52pm, roy.qing.li@...il.com wrote:
>> @@ -304,9 +303,11 @@ int ovs_dp_upcall(struct datapath *dp, struct sk_buff *skb,
>>       if (err)
>>               goto err;
>>
>> +     consume_skb(skb);
>>       return 0;
>
> What about the path from output_userspace()?

Right, output_userspace() can not free the skb in any case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ