netdev - Re: [PATCH 5/9] net: Have xmit_list() signal more==true when appropriate.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140902.135515.1879196973068806729.davem@davemloft.net>
Date:	Tue, 02 Sep 2014 13:55:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brouer@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/9] net: Have xmit_list() signal more==true when
 appropriate.

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Tue, 2 Sep 2014 09:25:38 +0200

> On Mon, 01 Sep 2014 15:24:59 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
> 
>>  		if (unlikely(!dev_xmit_complete(rc))) {
>>  			skb->next = next;
>>  			goto out;
> 
> In the exit case (!dev_xmit_complete(rc)) is it,
> 1. the responsibility of the driver to "flush" the tail, or
> 2. do we depend on qdisc or softirq to be reactivated soonish?

I think the driver will have to do it, much like it must do so when
the queue is stopped.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html