netdev - Re: [net-next PATCH 0/3] qdisc bulk dequeuing and utilizing delayed tailptr updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140902.140520.1169519726923476673.davem@davemloft.net>
Date:	Tue, 02 Sep 2014 14:05:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brouer@...hat.com
Cc:	netdev@...r.kernel.org, fw@...len.de, hannes@...essinduktion.org,
	dborkman@...hat.com
Subject: Re: [net-next PATCH 0/3] qdisc bulk dequeuing and utilizing
 delayed tailptr updates

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Tue, 02 Sep 2014 16:35:19 +0200

> Open questions:
> 
> - For now set bulk limit to 8 packets, don't want to stress the driver
>   avail ring_buffer space.

Maybe we can start out with something even lower, like 5.

> - Is the (!skb->next) check in dequeue necessary?
> 
> - Do we need some checks in dev_requeue_skb() as we could be requeuing a SKB list?

The skb->next stuff is to handle GSO software segmented frames.

dev_requeue_skb() naturally handles any list of SKBs already,
GSO software segmented or multi-dequeue, it shouldn't care.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html