netdev - Re: [PATCH 8/9] net: Don't keep around original SKB when we software segment GSO frames.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140901.184241.1951715714321502017.davem@davemloft.net>
Date:	Mon, 01 Sep 2014 18:42:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 8/9] net: Don't keep around original SKB when we
 software segment GSO frames.

From: Tom Herbert <therbert@...gle.com>
Date: Mon, 1 Sep 2014 18:28:18 -0700

> On Mon, Sep 1, 2014 at 3:25 PM, David Miller <davem@...emloft.net> wrote:
>>  struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device *dev);
>> -int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
>> -                       struct netdev_queue *txq);
>> +struct sk_buff *dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
>> +                                   struct netdev_queue *txq, int *ret);
> 
> Might be slightly better to still return int but pass struct sk_buff
> **skb. One less argument and doesn't change return type.

Sure we could do that, I don't have any preference either way and
besides there is only one call site.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html