lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Sep 2014 20:26:32 -0700 (PDT) From: David Miller <davem@...emloft.net> To: antoine.tenart@...e-electrons.com Cc: sebastian.hesselbarth@...il.com, thomas.petazzoni@...e-electrons.com, alexandre.belloni@...e-electrons.com, zmxu@...vell.com, jszhang@...vell.com, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] net: mvberlin_eth: add an Ethernet driver for Marvell Berlin From: Antoine Tenart <antoine.tenart@...e-electrons.com> Date: Fri, 29 Aug 2014 15:50:59 +0200 > +struct rx_desc { > + u16 buf_size; /* Buffer size */ > + u16 byte_cnt; /* Descriptor buffer byte count */ ... > + u16 byte_cnt; /* buffer byte count */ > + u16 l4i_chk; /* CPU provided TCP checksum */ I'm really suspcious that you're ordering these two members differently than that used by the mv643xx_eth driver. Looking at a diff of the two drivers, most of the transmit and recieve paths are largely the same. WRT. register differences, adding indirection to handle that is a no-brainer because the cost of the register access itself will absolutely dwarf whatever it costs to do an indirect call or whatever to implement the register access. I really think you should look into sharing code more seriously. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists