netdev - Re: [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2014-08-29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140901.203152.216310411574954349.davem@davemloft.net>
Date:	Mon, 01 Sep 2014 20:31:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates
 2014-08-29

From: Tom Lendacky <thomas.lendacky@....com>
Date: Fri, 29 Aug 2014 10:21:48 -0500

> The amd-xgbe-phy phylib driver support is integral to the amd-xgbe
> driver and isn't meant to be used by other devices.  For this reason
> it is being removed from the driver/net/phy directory and integrated
> into the amd-xgbe driver.

I see no real reason to do this.

Keeping it in the phylib layer forces you to deal with the abstractions
and therefore keeps you from bypassing the phylib API and performing
layer violations.

Please just keep the PHY driver where it is and add your new features
there.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html