netdev - Re: [PATCH net v5 4/4] tg3: Fix tx_pending checks for tg3_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140901.212328.1826121359590626658.davem@davemloft.net>
Date:	Mon, 01 Sep 2014 21:23:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bpoirier@...e.de
Cc:	prashant@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v5 4/4] tg3: Fix tx_pending checks for tg3_tso_bug

From: Benjamin Poirier <bpoirier@...e.de>
Date: Fri, 29 Aug 2014 13:46:31 -0700

> This puts us in the exceptional situation that a single skb that
> triggers tg3_tso_bug() may require the entire tx ring.

This is really silly.

If you get fed crap, linearize the SKB, end of story.

Don't try to be clever, and absolutely do not adjust gso_max_segs on
the fly as it was never ever designed to change dynamically and
asynchronously to the code paths which use it to size outgoing TCP
segments.

Nothing else needs adjusting, just linearize when you run into a
packet that can't fit into the TX ring because of these weird
restrictions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html