netdev - Re: [net-next PATCH 3/3] qdisc: sysctl to adjust bulk dequeue limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx_GSvXNY3wgbu25Kb5ZZsqMUb9thdiqg4AL-Q6EMGPV5w@mail.gmail.com>
Date:	Tue, 2 Sep 2014 17:12:03 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Jesper Dangaard Brouer <brouer@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Florian Westphal <fw@...len.de>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Daniel Borkmann <dborkman@...hat.com>
Subject: Re: [net-next PATCH 3/3] qdisc: sysctl to adjust bulk dequeue limit

On Tue, Sep 2, 2014 at 2:20 PM, Cong Wang <cwang@...pensource.com> wrote:
>
> On Tue, Sep 2, 2014 at 7:36 AM, Jesper Dangaard Brouer
> <brouer@...hat.com> wrote:
> > Allow userspace to adjust how many packet the qdisc is allowed to
> > bulk dequeue.
> >
> > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> >
> > ---
> > Question should we allow this to be adjusted?
> >
>
> A sysctl is ugly and seems not fit well with Qdisc which always uses netlink,
> so I think a netlink flag might be better if we can find a generic one.
>
You could also make this a device specific attribute easily enough.

> Also, you forgot to document it.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html