lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Sep 2014 06:43:25 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Jesper Dangaard Brouer <brouer@...hat.com> Cc: "David S. Miller" <davem@...emloft.net>, Alexander Duyck <alexander.duyck@...il.com>, netdev@...r.kernel.org Subject: Re: [net-next PATCH] qdisc: validate frames going through the direct_xmit path On Wed, 2014-09-03 at 13:48 +0200, Jesper Dangaard Brouer wrote: > In commit 50cbe9ab5f8d ("net: Validate xmit SKBs right when we pull them > out of the qdisc") the validation code was moved out of dev_hard_start_xmit > and into dequeue_skb. However this overlooked the fact that we do not > always enqueue the skb onto a qdisc, if qdisc have flag TCQ_F_CAN_BYPASS. > > As a result Alex was seeing issues trying to connect to a vhost_net interface > after this patch was applied. > > Added a call to validate_xmit_skb in __dev_xmit_skb(), in the code path > for qdiscs with TCQ_F_CAN_BYPASS flag. > > Fixes: 50cbe9ab5f8d ("net: Validate xmit SKBs right when we pull them out of the qdisc") > Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com> > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com> > --- Jesper, you missed another spot, when there is no qdisc on the device. __dev_queue_xmit() calls dev_hard_start_xmit() around line 2886 Could we try to not add a myriad of small patches ? Some of us will need to backport all of them. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists