netdev - Re: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Sep 2014 18:37:16 +0200
From:	PERIER Romain <romain.perier@...il.com>
To:	Naoki FUKAUMI <naobsd@...il.com>
Cc:	Heiko Stübner <heiko@...ech.de>,
	linux-rockchip@...ts.infradead.org,
	devicetree <devicetree@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/4] ARM: dts: Enable emac node on the rk3188-radxarock boards

It is an optional property used by arc-emac (the core driver), if it
is not present the core driver generates one for you.
Problem being that with this property two radxa rock boards connected
on the same local network might have the same mac address.

In this case it would be probably better to remove this property. What
do you think ?

2014-09-03 17:29 GMT+02:00 Naoki FUKAUMI <naobsd@...il.com>:
> On Wed, Sep 3, 2014 at 7:27 PM, Romain Perier <romain.perier@...il.com> wrote:
>> This enables EMAC Rockchip support on radxa rock boards.
>>
>> Signed-off-by: Romain Perier <romain.perier@...il.com>
>> ---
>>  arch/arm/boot/dts/rk3188-radxarock.dts | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
>> index 5e4e3c23..e1358d3 100644
>> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
>> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
>> @@ -76,6 +76,24 @@
>>         };
>>  };
>>
>> +&emac {
>> +       status = "okay";
>> +       compatible = "rockchip,rk3188-emac";
>> +
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
>> +
>> +       mac-address = [ c6 ef 91 8e 60 4b ];
>
> is "mac-address" required?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html