netdev - Re: [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409766781.26422.51.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 03 Sep 2014 10:53:01 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Rick Jones <raj@...dy.usa.hp.com>
Cc:	netdev@...r.kernel.org, amirv@...lanox.com, davem@...emloft.net
Subject: Re: [PATCH net-next] mlx4_en: Convert the normal skb free path to
 dev_consume_skb_any()

On Wed, 2014-09-03 at 09:18 -0700, Rick Jones wrote:
> From: Rick Jones <rick.jones2@...com>
> 
> It would appear the mlx4_en driver was still making a call to
> dev_kfree_skb_any() where dev_consume_skb_any() would be more
> appropriate.  This should make dropped packet profiling/tracking
> easier/better over a NIC driven by mlx4_en.
> 
> Signed-off-by: Rick Jones <rick.jones2@...com>
> 
> ---
> 
> Compile tested only
> 
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> index dae3da6..bc8f51c 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
> @@ -319,7 +319,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv,
>  			}
>  		}
>  	}
> -	dev_kfree_skb_any(skb);
> +	dev_consume_skb_any(skb);
>  	return tx_info->nr_txbb;
>  }
>  

I use a similar patch here, I confirm this works.

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html