netdev - Re: [PATCH v2] openvswitch: distinguish between the dropped and consumed skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+qTNTAH=XaPh86BvRntLzSNnRXYLSJpkdpGJJgVNbVODA@mail.gmail.com>
Date:	Wed, 3 Sep 2014 13:36:26 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	roy.qing.li@...il.com
Cc:	netdev <netdev@...r.kernel.org>,
	Thomas Graf <tgraf@...ronetworks.com>
Subject: Re: [PATCH v2] openvswitch: distinguish between the dropped and
 consumed skb

On Wed, Sep 3, 2014 at 2:43 AM,  <roy.qing.li@...il.com> wrote:
> From: Li RongQing <roy.qing.li@...il.com>
>
> distinguish between the dropped and consumed skb, not assume the skb
> is consumed always
>
> Cc: Thomas Graf <tgraf@...ronetworks.com>
> Cc: Pravin Shelar <pshelar@...ira.com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Acked-by: Pravin B Shelar <pshelar@...ira.com>

Thanks.
> ---
>  net/openvswitch/datapath.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 35d866f..91d66b7 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -265,8 +265,11 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)
>                 upcall.key = &key;
>                 upcall.userdata = NULL;
>                 upcall.portid = ovs_vport_find_upcall_portid(p, skb);
> -               ovs_dp_upcall(dp, skb, &upcall);
> -               consume_skb(skb);
> +               error = ovs_dp_upcall(dp, skb, &upcall);
> +               if (unlikely(error))
> +                       kfree_skb(skb);
> +               else
> +                       consume_skb(skb);
>                 stats_counter = &stats->n_missed;
>                 goto out;
>         }
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html