netdev - Re: [PATCH 2/2] net-timestamp: Make the clone operation stand-alone from phy timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409781908.26422.55.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 03 Sep 2014 15:05:08 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	netdev@...r.kernel.org, richardcochran@...il.com,
	davem@...emloft.net, willemb@...gle.com
Subject: Re: [PATCH 2/2] net-timestamp: Make the clone operation stand-alone
 from phy timestamping

On Wed, 2014-09-03 at 14:07 -0700, Eric Dumazet wrote:

> 
> Normally, if one skb holds a reference to a socket, it should have
> skb->destructor set to a cleanup function.
> 
> Otherwise, we rely on callers following a convention, to release sk
> reference.
> 
> If you believe its needed, it should be dully documented.


BTW, skb_orphan() would BUG() on this case (skb->destrutor == NULL and
skb->sk != NULL)





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html