netdev - RE: [PATCH net] core: Don't attempt to load the "" driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1748630E@AcuExch.aculab.com>
Date:	Wed, 3 Sep 2014 09:02:56 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Cong Wang' <cwang@...pensource.com>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: RE: [PATCH net] core: Don't attempt to load the "" driver.

> On Tue, Sep 2, 2014 at 6:48 AM, David Laight <David.Laight@...lab.com> wrote:
> > While the applications shouldn't be calling an SIOCxxx ioctl with ifr_name[0] == 0
> > the kernel shouldn't be tracing the error either.
> >
> 
> Why don't we reject this empty string? It doesn't look like a valid one.
> I assume this is for compatibility?

The ioctl code will error it later on - the module load is 'speculative'.
Analysing whether all the ioctls need dev_load() to succeed is another issue.

Indeed I'm not sure anything stops the module being unloaded before the
ioctl action tries to take a real reference on the interface.

Whether request_module("") should be an error is a different question,
probably much harder to analyse.

	David