netdev - Re: [PATCH] net: ethernet: cpsw: improve interrupt lookup logic in cpsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540871DA.7090608@ti.com>
Date:	Thu, 4 Sep 2014 19:36:18 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Daniel Mack <daniel@...que.org>, <davem@...emloft.net>
CC:	<julia.lawall@...6.fr>, <netdev@...r.kernel.org>,
	<george.cherian@...com>, Daniel Mack <zonque@...il.com>
Subject: Re: [PATCH] net: ethernet: cpsw: improve interrupt lookup logic in
 cpsw_probe()

On Thursday 04 September 2014 12:30 PM, Daniel Mack wrote:
> From: Daniel Mack <zonque@...il.com>
> 
> Simplify the interrupt resource lookup code in cpsw_probe() by the
> following:
> 
>  * Only look at the first member of the resource. As the driver only
>    works for DT-enabled platforms anyway, a resource of type
>    IORESOURCE_IRQ will only contain one single entry
>    (res->start == res->end), so there is no need for the iteration.
> 
>  * Add a bounds check to avoid overflows if we are passed more than
>    ARRAY_SIZE(priv->irqs_table) resources.
> 
>  * Assign 'ret' with the return value of devm_request_irq() so that
>    cpsw_probe() returns the appropriate error code.
> 
>  * If devm_request_irq() fails, report the error code in the log
>    message.
> 
> Signed-off-by: Daniel Mack <zonque@...il.com>

Acked-by: Mugunthan V N <mugunthanvnm@...il.com>

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html