netdev - Re: [PATCH] ip monitor: Dont print timestamp or banner-label for cloned routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMw6YJL_-6_zXo9tmEz3M8V-CxeoaAN_y0wscDt+JsM8xKkqAw@mail.gmail.com>
Date:	Thu, 4 Sep 2014 22:35:16 +0300
From:	Vadim Kochan <vadim4j@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ip monitor: Dont print timestamp or banner-label for
 cloned routes

Thanks!

Should I re-send the fixed patch with some special subject after
comments/review ?

On Thu, Sep 4, 2014 at 10:29 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 09/04/2014 10:52 PM, Vadim Kochan wrote:
>
>> This is ugly fix but solves the case when timestamp
>> or banner-label is printed before the cloned route will be skipped
>> by iproute filter which filters out all cached routes by default.
>> In such case timestamp will be printed twice:
>
>
>>      Timestamp: Thu Sep  4 19:46:59 2014 457933 usec
>>      Timestamp: Thu Sep  4 19:47:07 2014 977970 usec
>>      10.3.5.1 dev wlp3s0 lladdr XX:XX:XX:XX:XX:XX STALE
>
>
>> Signed-off-by: Vadim Kochan <vadim4j@...il.com>
>> ---
>>   ip/ipmonitor.c | 13 ++++++++++---
>>   1 file changed, 10 insertions(+), 3 deletions(-)
>
>
>> diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c
>> index 70f2a7a..2bd3fed 100644
>> --- a/ip/ipmonitor.c
>> +++ b/ip/ipmonitor.c
>
> [...]
>
>> @@ -53,6 +50,12 @@ static int accept_msg(const struct sockaddr_nl *who,
>>                         return -1;
>>                 }
>>
>> +               if (r->rtm_flags&RTM_F_CLONED)
>
>
>    Judging on the patched code, spaces are needed around &.
>
>
>> +                       return 0;
>> +
>> +               if (timestamp)
>> +                       print_timestamp(fp);
>> +
>>                 if (r->rtm_family == RTNL_FAMILY_IPMR ||
>>                     r->rtm_family == RTNL_FAMILY_IP6MR) {
>>                         if (prefix_banner)
>
> [...]
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html