netdev - Re: netfilter: NETFILTER_XT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1409815844.5546.71.camel@x220>
Date:	Thu, 04 Sep 2014 09:30:44 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	Matteo Croce <technoboy85@...il.com>,
	Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org
Subject: Re: netfilter: NETFILTER_XT_NAT?

On Thu, 2014-09-04 at 09:20 +0200, Pablo Neira Ayuso wrote:
> We never had so far a way to enable/disable the xt_nat targets from
> Kconfig, before this patch that was controled by CONFIG_NF_NAT which
> is a global switch to enable/disable NAT.
> 
> With that patch, the idea is that users still get the {S,D}NAT target
> if the IPv4/IPv6 iptables NAT tables are enabled (thus the two select
> statements) when jumping from old kernel config to new ones.
> 
> I can introduce a new explicit switch for NETFILTER_XT_NAT in Kconfig
> for this if you consider that less confusing, it's something we didn't
> have so far though. Please, let me know if I'm overlooking something
> incorrect, thanks.

My point was that you probably need to add a Kconfig entry for
NETFILTER_XT_NAT. Because now, at least in next-21040903, the two select
statements are NOPs and xt_nat.o will never be build because
CONFIG_NETFILTER_XT_NAT will never be set:
    $ git grep NETFILTER_XT_NAT next-20140903
    next-20140903:net/ipv4/netfilter/Kconfig:       select NETFILTER_XT_NAT
    next-20140903:net/ipv6/netfilter/Kconfig:       select NETFILTER_XT_NAT
    next-20140903:net/netfilter/Makefile:obj-$(CONFIG_NETFILTER_XT_NAT) += xt_nat.o

Perhaps that Kconfig entry get dropped while resolving a merge conflict,
somewhere.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html