netdev - Compilation error on freshly pulled net-next?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Sep 2014 14:47:43 -0700
From:	Rick Jones <rick.jones2@...com>
To:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Compilation error on freshly pulled net-next?

I was going to do some additional "floor sweeping" and put 
dev_consume_skb_any() into another driver or two, so I did a fresh pull 
of net-next and a make and got:

   CC      net/core/rtnetlink.o
net/core/rtnetlink.c: In function ‘if_nlmsg_size’:
net/core/rtnetlink.c:868:84: error: expected ‘;’ before ‘J’
net/core/rtnetlink.c: At top level:
net/core/rtnetlink.c:420:15: warning: ‘rtnl_link_get_size’ defined but 
not used [-Wunused-function]
net/core/rtnetlink.c:497:15: warning: ‘rtnl_link_get_af_size’ defined 
but not used [-Wunused-function]


Looks like someone slipped a J in there and confused things:

                + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS 
+ IFLA_PORT_SELF */J            + rtnl_link_get_size(dev) /* 
IFLA_LINKINFO */
                + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */

(hopefully my mail client won't have mangled things too badly)

What is odd though is a git diff after I've replaced that 'J' with a 
return isn't giving me any output.

rick jones
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html