netdev - Re: [PATCH net-next 1/3] net: Add function for parsing the header length out of linear ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <540A43FE.7050708@intel.com>
Date:	Fri, 05 Sep 2014 16:15:10 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH net-next 1/3] net: Add function for parsing the header
 length out of linear ethernet frames

On 09/05/2014 01:02 PM, Alexei Starovoitov wrote:
> On Fri, Sep 5, 2014 at 11:10 AM, Alexander Duyck
> <alexander.h.duyck@...el.com> wrote:
>> This patch updates some of the flow_dissector api so that it can be used to
>> parse the length of ethernet buffers stored in fragments.  Most of the
>> changes needed were to __skb_get_poff as it needed to be updated to support
>> sending a linear buffer instead of a skb.
>>
>>
>>  u32 __skb_get_poff(const struct sk_buff *skb);
>> +u32 ___skb_get_poff(const struct sk_buff *skb, void *data,
>> +                   const struct flow_keys *keys, int hlen);
> 
> three underscores and not a static function?
> May be we need to come with a proper name for it.
> Two easy to confuse with two underscore version...

Actually what I could do is probably rename the 2 underscore version to
drop the underscores and then rename the 3 underscore version to just 2
underscores.  Then it would match up closer with how the other functions
are dealing with the data/hlen values.

Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html