netdev - Re: [PATCH net-next v2 1/3] net: Add function for parsing the header length out of linear ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140905233910.GA19153@its-macbook-pro.plumgrid.com>
Date:	Fri, 5 Sep 2014 16:39:12 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	eric.dumazet@...il.com, jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH net-next v2 1/3] net: Add function for parsing the header
 length out of linear ethernet frames

On Fri, Sep 05, 2014 at 07:20:26PM -0400, Alexander Duyck wrote:
> This patch updates some of the flow_dissector api so that it can be used to
> parse the length of ethernet buffers stored in fragments.  Most of the
> changes needed were to __skb_get_poff as it needed to be updated to support
> sending a linear buffer instead of a skb.
> 
> I have split __skb_get_poff into two functions, the first is skb_get_poff
> and it retains the functionality of the original __skb_get_poff.  The other
> function is __skb_get_poff which now works much like __skb_flow_dissect in
> relation to skb_flow_dissect in that it provides the same functionality but
> works with just a data buffer and hlen instead of needing an skb.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
>  include/linux/etherdevice.h |    1 +
>  include/linux/skbuff.h      |    4 +++-
>  include/net/flow_keys.h     |    2 ++
>  net/core/filter.c           |    2 +-
>  net/core/flow_dissector.c   |   46 ++++++++++++++++++++++++++++++-------------
>  net/ethernet/eth.c          |   27 +++++++++++++++++++++++++
>  6 files changed, 66 insertions(+), 16 deletions(-)

names and bpf related bits look good to me
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html