netdev - Re: [net-next PATCH] qdisc: exit case fixes for skb list handling in qdisc layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140904.224155.345294600116542200.davem@davemloft.net>
Date:	Thu, 04 Sep 2014 22:41:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brouer@...hat.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, fw@...len.de,
	hannes@...essinduktion.org, dborkman@...hat.com
Subject: Re: [net-next PATCH] qdisc: exit case fixes for skb list handling
 in qdisc layer

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Thu, 4 Sep 2014 07:39:12 +0200

> On Wed, 03 Sep 2014 22:24:19 -0700
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>> On Wed, 2014-09-03 at 20:42 -0700, David Miller wrote:
>> > From: Jesper Dangaard Brouer <brouer@...hat.com>
>> > Date: Wed, 03 Sep 2014 12:12:50 +0200
>> > 
>> > > More minor fixes to merge commit 53fda7f7f9e (Merge branch 'xmit_list')
>> > > that allows us to work with a list of SKBs.
>> > > 
>> > > Fixing exit cases in qdisc_reset() and qdisc_destroy(), where a
>> > > leftover requeued SKB (qdisc->gso_skb) can have the potential of
>> > > being a skb list, thus use kfree_skb_list().
>> > > 
>> > > This is a followup to commit 10770bc2d1 ("qdisc: adjustments for
>> > > API allowing skb list xmits").
>> > > 
>> > > Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
>> > 
>> > Applied.
>> 
>> Strange, I sent same patch a little earlier ;)
> 
> Yes, very strange, especially as Dave also said he had applied your
> patch too (I did comment on your post, apologizing for not noticing
> your patch, before sending this one).

This is my fault.

I put Eric's copy into my GIT tree on my workstation at home, build
tested it, but did not push it out.

Then I did GIT work from my laptop for the following two days. :-/

Sorry about that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html