netdev - Re: [patch iproute2] add help command to bonding master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140905135355.GC1923@nanopsycho.lan>
Date:	Fri, 5 Sep 2014 15:53:55 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Vadim Kochan <vadim4j@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Stephen Hemminger <stephen@...workplumber.org>,
	nikolay@...hat.com
Subject: Re: [patch iproute2] add help command to bonding master

Fri, Sep 05, 2014 at 03:41:14PM CEST, vadim4j@...il.com wrote:
>Sorry, may be this is not related to this particular patch:
>
>    would not it better to use usage() name instead of explain() as it
>is used everywhere ?

Well, yes, that is certainly doable. Feel free to send patch.


>
>On Fri, Sep 5, 2014 at 4:24 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>> ---
>>  ip/iplink_bond.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c
>> index b5c511e..0a1ed03 100644
>> --- a/ip/iplink_bond.c
>> +++ b/ip/iplink_bond.c
>> @@ -339,6 +339,9 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
>>                         }
>>                         ad_select = get_index(ad_select_tbl, *argv);
>>                         addattr8(n, 1024, IFLA_BOND_AD_SELECT, ad_select);
>> +               } else if (matches(*argv, "help") == 0) {
>> +                       explain();
>> +                       return -1;
>>                 } else {
>>                         fprintf(stderr, "bond: unknown command \"%s\"?\n", *argv);
>>                         explain();
>> --
>> 1.9.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html