netdev - Re: [PATCH] rose: use %*ph specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409930571.30155.94.camel@linux.intel.com>
Date:	Fri, 05 Sep 2014 18:22:51 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-hams@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] rose: use %*ph specifier

On Fri, 2014-09-05 at 08:17 -0700, Eric Dumazet wrote:
> On Fri, 2014-09-05 at 18:01 +0300, Andy Shevchenko wrote:
> > Instead of dereference each byte let's use %*ph specifier in the printk()
> > calls.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  net/rose/rose_link.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/rose/rose_link.c b/net/rose/rose_link.c
> > index bc55142..ce60771 100644
> > --- a/net/rose/rose_link.c
> > +++ b/net/rose/rose_link.c
> > @@ -160,7 +160,7 @@ void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsigne
> >  		break;
> >  
> >  	case ROSE_DIAGNOSTIC:
> > -		printk(KERN_WARNING "ROSE: received diagnostic #%d - %02X %02X %02X\n", skb->data[3], skb->data[4], skb->data[5], skb->data[6]);
> > +		pr_warn("ROSE: received diagnostic #%d - %4ph\n", skb->data + 3);
> >  		break;
> >  
> >  	default:
> 
> That can not be correct.

Yes, you right.

> 
> Have you even compiled this ?

Apparently not this time.


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html