netdev - Re: [PATCH] greth: moved TX ring cleaning to NAPI rx poll func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140905.215735.435013223458340103.davem@davemloft.net>
Date:	Fri, 05 Sep 2014 21:57:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...sler.com
Cc:	netdev@...r.kernel.org, software@...sler.com
Subject: Re: [PATCH] greth: moved TX ring cleaning to NAPI rx poll func

From: Daniel Hellstrom <daniel@...sler.com>
Date: Fri,  5 Sep 2014 13:13:48 +0200

> This patch does not affect the 10/100 GRETH MAC.
> 
> Before all GBit GRETH TX descriptor ring cleaning was done in
> start_xmit(), when descriptor list became full it activated
> TX interrupt to start the NAPI rx poll function to do TX ring
> cleaning.
> 
> With this patch the TX descriptor ring is always cleaned from
> the NAPI rx poll function, triggered via TX or RX interrupt.
> Otherwise we could end up in TX frames being sent but not
> reported to the stack being sent. On the 10/100 GRETH this
> is not an issue since the SKB is copied&aligned into private
> buffers so that the SKB can be freed directly on start_xmit()
> 
> Signed-off-by: Daniel Hellstrom <daniel@...sler.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html