netdev - Re: [PATCH v2] iproute2 tests: Fix problem with test running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMw6YJ+5qR2o6NNwD7RNPLoqLwMDT57kWXRQWehYJwbiQA4nYg@mail.gmail.com>
Date:	Sat, 6 Sep 2014 13:31:09 +0300
From:	Vadim Kochan <vadim4j@...il.com>
To:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vadim Kochan <vadim4j@...il.com>
Subject: Re: [PATCH v2] iproute2 tests: Fix problem with test running

I will re-send patch v2 with using "sudo -E".

On Fri, Sep 5, 2014 at 8:10 PM, Vadim Kochan <vadim4j@...il.com> wrote:
> Tests were not allowed to be ran, the following
> issues were fixed:
>     - creating the results folder before test running
>     - sudo $PREFIX moved before variables definition which
>         allow to pass them through the sudo to test script.
>
> Signed-off-by: Vadim Kochan <vadim4j@...il.com>
> ---
>  testsuite/Makefile | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 2a4e0ba..648c793 100644
> --- a/testsuite/Makefile
> +++ b/testsuite/Makefile
> @@ -1,6 +1,7 @@
>  ## -- Config --
>  DEV := lo
>  PREFIX := sudo
> +RESULTS_DIR := results
>  ## -- End Config --
>
>  TESTS := $(patsubst tests/%,%,$(wildcard tests/*.t))
> @@ -23,23 +24,24 @@ listtests:
>  alltests: $(TESTS)
>
>  clean:
> -       @rm -rf results/*
> +       @rm -rf $(RESULTS_DIR)
>
>  distclean: clean
>         echo "Entering iproute2" && cd iproute2 && $(MAKE) distclean && cd ..;
>
>  $(TESTS):
> +       @mkdir -p $(RESULTS_DIR)
>         @for i in $(IPVERS); do \
>                 o=`echo $$i | sed -e 's/iproute2\///'`; \
>                 echo -n "Running $@ [$$o/`uname -r`]: "; \
> -               TC="$$i/tc/tc" IP="$$i/ip/ip" DEV="$(DEV)" IPVER="$@" SNAME="$$i" \
> -               ERRF="results/$@...o.err" $(KENV) $(PREFIX) tests/$@ > results/$@...o.out; \
> +               $(PREFIX) TC="$$i/tc/tc" IP="$$i/ip/ip" DEV="$(DEV)" IPVER="$@" SNAME="$$i" \
> +               ERRF="$(RESULTS_DIR)/$@...o.err" $(KENV) tests/$@ > $(RESULTS_DIR)/$@...o.out; \
>                 if [ "$$?" = "127" ]; then \
>                         echo "SKIPPED"; \
> -               elif [ -e "results/$@...o.err" ]; then \
> +               elif [ -e "$(RESULTS_DIR)/$@...o.err" ]; then \
>                         echo "FAILED"; \
>                 else \
>                         echo "PASS"; \
>                 fi; \
> -               dmesg > results/$@...o.dmesg; \
> +               dmesg > $(RESULTS_DIR)/$@...o.dmesg; \
>         done
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html