netdev - Re: [PATCH net-next] tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410017436.11872.32.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 06 Sep 2014 08:30:36 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Neal Cardwell <ncardwell@...gle.com>
Cc:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	ycheng@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: remove obsolete comment about
 TCP_SKB_CB(skb)->when in tcp_fragment()

On Sat, 2014-09-06 at 11:18 -0400, Neal Cardwell wrote:
> The TCP_SKB_CB(skb)->when field no longer exists as of recent change
> 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case,
> tcp_fragment() is called on already-transmitted packets from the
> __tcp_retransmit_skb() call site, so copying timestamps of any kind
> in this spot is quite sensible.
> 
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Reported-by: Yuchung Cheng <ycheng@...gle.com>
> ---
>  net/ipv4/tcp_output.c | 3 ---

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html