netdev - Re: [PATCH net-next 3/3] net: bpf: be friendly to kmemcheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuz5ec8=-x9QO+jjSENz+rKVdv0Avhupi4snSgUboSaKUA@mail.gmail.com>
Date:	Sat, 6 Sep 2014 09:09:51 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Mikulas Patocka <mpatocka@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: bpf: be friendly to kmemcheck

On Sat, Sep 6, 2014 at 2:42 AM, Daniel Borkmann <dborkman@...hat.com> wrote:
> Reported by Mikulas Patocka, kmemcheck currently barks out a
> false positive since we don't have special kmemcheck annotation
> for bitfields used in bpf_prog structure.
>
> We currently have jited:1, len:31 and thus when accessing len
> while CONFIG_KMEMCHECK enabled, kmemcheck throws a warning that
> we're reading uninitialized memory.
>
> As we don't need the whole bit universe for pages member, we
> can just split it to u16 and use a bool flag for jited instead
> of a bitfield.
>
> Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> Cc: Alexei Starovoitov <ast@...mgrid.com>
> ---
>  arch/arm/net/bpf_jit_32.c       | 2 +-
>  arch/mips/net/bpf_jit.c         | 2 +-
>  arch/powerpc/net/bpf_jit_comp.c | 2 +-
>  arch/s390/net/bpf_jit_comp.c    | 2 +-
>  arch/sparc/net/bpf_jit_comp.c   | 2 +-
>  arch/x86/net/bpf_jit_comp.c     | 2 +-
>  include/linux/filter.h          | 6 +++---
>  net/core/filter.c               | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)

This one also looks good. Thanks!
Acked-by: Alexei Starovoitov <ast@...mgrid.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html