lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140907204359.GA16055@localhost.localdomain> Date: Sun, 7 Sep 2014 16:43:59 -0400 From: Neil Horman <nhorman@...driver.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, klassert@...hematik.tu-chemnitz.de Subject: Re: [PATCH v3] 3c59x: avoid panic in boomerang_start_xmit when finding page address: On Fri, Sep 05, 2014 at 05:24:26PM -0700, David Miller wrote: > From: Neil Horman <nhorman@...driver.com> > Date: Thu, 4 Sep 2014 06:13:38 -0400 > > > This bug was reported on a very old kernel (RHEL6, 2.6.32-491.el6): > ... > > But the problem seems to still exist upstream. It seems on 32 bit kernels > > page_address() can reutrn a NULL value in some circumstances, and the > > pci_map_single api isn't prepared to handle that (on this system it results in a > > bogus pointer deference in nommu_map_page. > > > > The fix is pretty easy, if we convert the 3c59x driver to use the more > > convieient skb_frag_dma_map api we don't need to find the virtual address of the > > page at all, and page gets mapped to the hardware properly. Verified to fix the > > problem as described by the reporter. > > > > Applies to the net tree > > > > Change Notes: > > > > v2) Converted PCI_DMA_TODEVICE to DMA_TO_DEVICE. Thanks Dave! > > > > v3) Actually Run git commit after making changes to v2 :) > > > > Signed-off-by: Neil Horman <nhorman@...driver.com> > > Applied, thanks Neil. > Thanks Dave! Neil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists