netdev - Re: [PATCH] net: phy: mdio-sun4i: don't select REGULATOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140907.161230.1498704332590876012.davem@davemloft.net>
Date:	Sun, 07 Sep 2014 16:12:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	b.galvani@...il.com
Cc:	f.fainelli@...il.com, maxime.ripard@...e-electrons.com,
	arnd@...db.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: mdio-sun4i: don't select REGULATOR

From: Beniamino Galvani <b.galvani@...il.com>
Date: Sat,  6 Sep 2014 00:28:23 +0200

> The mdio-sun4i driver automatically selects REGULATOR and
> REGULATOR_FIXED_VOLTAGE because it uses the regulator API. But a
> driver selecting a subsystem increases the chance of generating
> circular Kconfig dependencies, especially when other drivers depend on
> the selected symbol.
> 
> Since the regulator API functions are replaced with no-ops when
> REGULATOR is disabled, the driver can be built successfully even
> without regulator support and so those 'select' dependencies can be
> safely dropped.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Beniamino Galvani <b.galvani@...il.com>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html