lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <540E05D1.4000802@perex.cz> Date: Mon, 08 Sep 2014 21:38:57 +0200 From: Jaroslav Kysela <perex@...ex.cz> To: Rick Jones <raj@...dy.usa.hp.com>, netdev@...r.kernel.org CC: davem@...emloft.net Subject: Re: [PATCH net-next] hp100: Convert the normal skb free path to dev_consume_skb_any() Date 8.9.2014 17:31, Rick Jones wrote: > From: Rick Jones <rick.jones2@...com> > > A bit of floor sweeping in a dusty old corner. Convert the "normal" > skb free calls to dev_consume_skb_any() so packet drop tracing will > be more sane. > > Signed-off-by: Rick Jones <rick.jones2@...com> Acked-by: Jaroslav Kysela <perex@...ex.cz> > > --- > > Compile tested only. I wonder how many of these cards are still in > operation?-) It's really old hw.. > > diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c > index ed7916f..76a6e0c 100644 > --- a/drivers/net/ethernet/hp/hp100.c > +++ b/drivers/net/ethernet/hp/hp100.c > @@ -1627,7 +1627,7 @@ static void hp100_clean_txring(struct net_device *dev) > #endif > /* Conversion to new PCI API : NOP */ > pci_unmap_single(lp->pci_dev, (dma_addr_t) lp->txrhead->pdl[1], lp->txrhead->pdl[2], PCI_DMA_TODEVICE); > - dev_kfree_skb_any(lp->txrhead->skb); > + dev_consume_skb_any(lp->txrhead->skb); > lp->txrhead->skb = NULL; > lp->txrhead = lp->txrhead->next; > lp->txrcommit--; > @@ -1745,7 +1745,7 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb, > hp100_ints_on(); > spin_unlock_irqrestore(&lp->lock, flags); > > - dev_kfree_skb_any(skb); > + dev_consume_skb_any(skb); > > #ifdef HP100_DEBUG_TX > printk("hp100: %s: start_xmit: end\n", dev->name); > -- Jaroslav Kysela <perex@...ex.cz> Linux Kernel Sound Maintainer ALSA Project; Red Hat, Inc. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists