lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140908.154108.1495360301996041738.davem@davemloft.net> Date: Mon, 08 Sep 2014 15:41:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: therbert@...gle.com, alexander.h.duyck@...el.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next] tcp: remove dst refcount false sharing for prequeue mode From: Eric Dumazet <eric.dumazet@...il.com> Date: Mon, 08 Sep 2014 14:30:42 -0700 > In the worst case, here is what is happening : > > sk_rx_dst is checked and invalidated in tcp_v4_do_rcv() > > Next packets coming from prequeue might then have a NULL dst, and > we'll do nothing special (sk_rx_dst will stay NULL), because we do > handle NULL dst properly in inet_sk_rx_dst_set() and > inet6_sk_rx_dst_set() > > But next packet to be processed (either in non prequeue mode or > prequeue) will carry skb->dst and we will set sk->sk_rx_dst > > I decided to not copy/paste the tests we do in the family dependent > parts, because it was not worth the pain. I must have mis-read some of these code paths, let me look over it again, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists