netdev - Re: [PATCH] drivers: net: ethernet: octeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540DDB0C.3070901@gmail.com>
Date:	Mon, 08 Sep 2014 09:36:28 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Aaro Koskinen <aaro.koskinen@....com>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
CC:	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] drivers: net: ethernet: octeon_mgmt: fix a compiler warning

On 09/08/2014 08:01 AM, Aaro Koskinen wrote:
> Fix the following compiler warning:
>
> drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_clean_tx_buffers':
> drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>      u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
>      ^
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....com>

For some reason we missed this when the initial patch was created. 
Thanks for fixing it...

Acked-by: David Daney <david.daney@...ium.com>


> ---
>   drivers/net/ethernet/octeon/octeon_mgmt.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
> index 979c698..a422930 100644
> --- a/drivers/net/ethernet/octeon/octeon_mgmt.c
> +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
> @@ -290,9 +290,11 @@ static void octeon_mgmt_clean_tx_buffers(struct octeon_mgmt *p)
>   		/* Read the hardware TX timestamp if one was recorded */
>   		if (unlikely(re.s.tstamp)) {
>   			struct skb_shared_hwtstamps ts;
> +			u64 ns;
> +
>   			memset(&ts, 0, sizeof(ts));
>   			/* Read the timestamp */
> -			u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
> +			ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
>   			/* Remove the timestamp from the FIFO */
>   			cvmx_write_csr(CVMX_MIXX_TSCTL(p->port), 0);
>   			/* Tell the kernel about the timestamp */
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html