netdev - Re: [net-next PATCH v3 05/15] net: sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2014 09:20:27 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	xiyou.wangcong@...il.com, davem@...emloft.net, jhs@...atatu.com,
	netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
	brouer@...hat.com
Subject: Re: [net-next PATCH v3 05/15] net: sched: cls_flow use RCU

On Tue, 2014-09-09 at 09:09 -0700, John Fastabend wrote:
> On 09/09/2014 05:41 AM, Eric Dumazet wrote:

> >>   struct flow_filter {
> >>   	struct list_head	list;
> >> +	struct rcu_head		rcu;
> >
> > Please move these 2 new fields at the end of structure, they are only
> > used at dismantle phase.
> >
> > Patch looks fine otherwise, thanks !
> >
> >
> 
> 2 new fields? The first rcu struct is already at end of
> structure. I assume you just mean the rcu struct in flow_filter.

Yes, I was referring to these fields.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html