netdev - Re: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540F8582.50703@infradead.org>
Date:	Tue, 09 Sep 2014 15:56:02 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Anish Bhatt <anish@...lsio.com>, Michael Chan <mchan@...adcom.com>,
	"eddie.wai@...adcom.com" <eddie.wai@...adcom.com>
CC:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	James Bottomley <jbottomley@...allels.com>
Subject: Re: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

On 09/09/14 14:08, Anish Bhatt wrote:
> 
>> Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but
>> works for SCSI_BNX2_ISCSI?
> 
> It fixes the config issue for both, but with FCOE; make scripts will complain about recursive dependencies with the following :
> 
> scripts/kconfig/conf --silentoldconfig Kconfig
> net/Kconfig:5:error: recursive dependency detected!
> net/Kconfig:5:  symbol NET is selected by SCSI_NETLINK
> drivers/scsi/Kconfig:43:        symbol SCSI_NETLINK is selected by SCSI_FC_ATTRS
> drivers/scsi/Kconfig:258:       symbol SCSI_FC_ATTRS is selected by LIBFC
> drivers/scsi/Kconfig:586:       symbol LIBFC is selected by SCSI_BNX2X_FCOE
> drivers/scsi/bnx2fc/Kconfig:1:  symbol SCSI_BNX2X_FCOE depends on IPV6
> net/ipv6/Kconfig:6:     symbol IPV6 depends on NET

It would be really good if SCSI_NETLINK depended on NET instead of selected NET.
We shouldn't have kconfig symbols that use 'select' on entire subsystems.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html