netdev - Re: [PATCH net-next] sfc: Convert the normal transmit complete path to dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2014 16:18:24 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Rick Jones <raj@...dy.usa.hp.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, sshah@...arflare.com,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next] sfc: Convert the normal transmit complete path
 to dev_consume_skb_any()

On Tue, 2014-09-09 at 14:43 -0700, Rick Jones wrote:
> From: Rick Jones <rick.jones2@...com>
> 
> Convert the normal transmit completion path from dev_kfree_skb_any()
> to dev_consume_skb_any() to help keep dropped packet profiling
> meaningful.
> 
> Signed-off-by: Rick Jones <rick.jones2@...com>
> 
> ---
> 
> Compile tested only.  Also a fixup to make scripts/checkpatch.pl
> happy.
> 
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index 65c220f..3206098 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -78,7 +78,7 @@ static void efx_dequeue_buffer(struct efx_tx_queue *tx_queue,
>  	if (buffer->flags & EFX_TX_BUF_SKB) {
>  		(*pkts_compl)++;
>  		(*bytes_compl) += buffer->skb->len;
> -		dev_kfree_skb_any((struct sk_buff *) buffer->skb);
> +		dev_consume_skb_any((struct sk_buff *)buffer->skb);
>  		netif_vdbg(tx_queue->efx, tx_done, tx_queue->efx->net_dev,
>  			   "TX queue %d transmission id %x complete\n",
>  			   tx_queue->queue, tx_queue->read_count);

Right, but please remove this ugly cast while you are at it ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html