netdev - Re: [PATCH ipvs] Added simple weighted failover scheduler to ipvs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1409090834190.2676@ja.home.ssi.bg>
Date:	Tue, 9 Sep 2014 08:57:46 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Kenny Mathis <kmathis@...kepoint.net>
cc:	netdev@...r.kernel.org, Wensong Zhang <wensong@...ux-vs.org>,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [PATCH ipvs] Added simple weighted failover scheduler to ipvs


	Hello,

On Mon, 8 Sep 2014, Kenny Mathis wrote:

> Please consider this patch for addition in 3.17
> 
> Creates net/netfilter/ipvs/ip_vs_fo.c

	Lines like the two above usually go after
the '---' line. New features go first to the
{ipvs,nf,net}-next trees.

> Added simple weighted IPVS failover support to the Linux kernel.  All
> other scheduling modules implement some form of load balancing, while 
> this offers a simple failover solution.  Connections are directed to the
> appropriate server based solely on highest weight value and server
> availability.  Tested functionality with keepalived.

	What about changing 'Added' with 'Add', using
'ipvs: Add simple ...' in Subject line and reducing the
many spaces in above comments to one? The main thing,
there must be a Signed-off-by: line:

# scripts/checkpatch.pl --strict /tmp/fo.diff 
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 102 lines checked

/tmp/fo.diff has style problems, please review.

> +static struct ip_vs_dest *
> +ip_vs_fo_schedule(struct ip_vs_service *svc, const struct sk_buff *skb,
> +		  struct ip_vs_iphdr *iph)
> +{
> +	struct ip_vs_dest *dest = NULL, *hweight = NULL;

	' = NULL' after dest is not needed. Otherwise,
the module looks correctly implemented. You can post
PATCHv2 after making all needed changes.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html