netdev - Re: [Patch v2 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5AFUKeKpPrOzVe+GqhSzF0Hg2dK3HPf4X+4r0G-EH2iZA@mail.gmail.com>
Date:	Wed, 10 Sep 2014 10:27:51 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Zhi Li <lznuaa@...il.com>
Cc:	Frank Li <Frank.Li@...escale.com>,
	Duan Fugang-B38611 <b38611@...escale.com>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [Patch v2 net-next 09/12] net: fec: change FEC alignment
 according to i.mx6 sx requirement

On Wed, Sep 10, 2014 at 10:22 AM, Zhi Li <lznuaa@...il.com> wrote:
> On Wed, Sep 10, 2014 at 7:51 AM, Fabio Estevam <festevam@...il.com> wrote:
>> On Tue, Sep 9, 2014 at 5:15 PM, Frank Li <Frank.Li@...escale.com> wrote:
>>
>>> +       fep->rx_align = 0x3;
>>> +       fep->tx_align = 0x3;
>>
>> Why do you unconditionally set it as 0x3? It was 0xf for ARM and 0x3
>> for non-ARM.
>
> Will fix it at next version.

Also, please make sure to add Russell King on Cc in the next version.
He has recently done a lot of work in this driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html