lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Sep 2014 19:16:23 +0200 From: Sabrina Dubroca <sd@...asysnail.net> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev@...r.kernel.org, Hannes Frederic Sowa <hannes@...essinduktion.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [Patch net-next 4/5] ipv6: drop ipv6_sk_mc_lock in mcast Hello, 2014-09-09, 16:52:17 -0700, Cong Wang wrote: > Similarly the code is already protected by rtnl lock. > > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> > --- > net/ipv6/mcast.c | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) > > diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > index 6833dd0..d2b7dd8 100644 > --- a/net/ipv6/mcast.c > +++ b/net/ipv6/mcast.c > @@ -82,9 +82,6 @@ static void *__mld2_query_bugs[] __attribute__((__unused__)) = { > > static struct in6_addr mld2_all_mcr = MLD2_ALL_MCR_INIT; > > -/* Big mc list lock for all the sockets */ > -static DEFINE_SPINLOCK(ipv6_sk_mc_lock); > - Just a small thing: there are a few comments in the file that still refer to this lock (as ipv6_sk_mc_lock or ip6_sk_mc_lock): -- /* * changes to the ipv6_mc_list require the socket lock and * a read lock on ip6_sk_mc_lock. We have the socket lock, * so reading the list is safe. */ -- /* changes to psl require the socket lock, a read lock on * on ipv6_sk_mc_lock and a write lock on pmc->sflock. We * have the socket lock, so reading here is safe. */ -- /* callers have the socket lock and a write lock on ipv6_sk_mc_lock, * so no other readers or writers of iml or its sflist */ -- If you submit a v2 of this patchset, you could update them. Otherwise, I'll do it later. Thanks, -- Sabrina -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists