netdev - Re: [PATCH net-next v2] net: bpf: only build bpf_jit_binary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMEtUuzOO3zt45FZj7sR5+iWa+L7hCD32TBkyjW7ZsOg633T4g@mail.gmail.com>
Date:	Wed, 10 Sep 2014 10:22:02 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	kbuild test robot <fengguang.wu@...el.com>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: bpf: only build bpf_jit_binary_{alloc,free}()
 when jit selected

On Wed, Sep 10, 2014 at 6:01 AM, Daniel Borkmann <dborkman@...hat.com> wrote:
> Since BPF JIT depends on the availability of module_alloc() and
> module_free() helpers (HAVE_BPF_JIT and MODULES), we better build
> that code only in case we have BPF_JIT in our config enabled, just
> like with other JIT code. Fixes builds for arm/marzen_defconfig
> and sh/rsk7269_defconfig.
>
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Fixes: 738cbe72adc5 ("net: bpf: consolidate JIT binary allocator")
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

haven't tested it, but looks good to me, so
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

thank you for taking care of it so quickly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html