lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140910.135840.133555874665251669.davem@davemloft.net>
Date:	Wed, 10 Sep 2014 13:58:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	sd@...asysnail.net, netdev@...r.kernel.org,
	hannes@...essinduktion.org
Subject: Re: [PATCH net] ipv6: clean up anycast when an interface is
 destroyed

From: Cong Wang <cwang@...pensource.com>
Date: Wed, 10 Sep 2014 10:15:01 -0700

> On Wed, Sep 10, 2014 at 3:27 AM, Sabrina Dubroca <sd@...asysnail.net> wrote:
>> diff --git a/net/ipv6/anycast.c b/net/ipv6/anycast.c
>> index ff2de7d9d8e6..a1bf80574bfe 100644
>> --- a/net/ipv6/anycast.c
>> +++ b/net/ipv6/anycast.c
>> @@ -351,6 +351,28 @@ static int ipv6_dev_ac_dec(struct net_device *dev, const struct in6_addr *addr)
>>         return __ipv6_dev_ac_dec(idev, addr);
>>  }
>>
>> +/* Device is being destroyed: clean up */
> 
> This comment is useless.

Agreed, please remove this and respin that patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ