netdev - Re: [PATCH] udp: Fix inverted NAPI_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Sep 2014 22:13:48 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Scott Wood <scottwood@...escale.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH] udp: Fix inverted NAPI_GRO_CB(skb)->flush test

On Wed, 2014-09-10 at 21:23 -0500, Scott Wood wrote:
> Commit 2abb7cdc0d ("udp: Add support for doing checksum unnecessary
> conversion") caused napi_gro_cb structs with the "flush" field zero to
> take the "udp_gro_receive" path rather than the "set flush to 1" path
> that they would previously take.  As a result I saw booting from an NFS
> root hang shortly after starting userspace, with "server not
> responding" messages.
> 
> This change to the handling of "flush == 0" packets appears to be
> incidental to the goal of adding new code in the case where
> skb_gro_checksum_validate_zero_check() returns zero.  Based on that and
> the fact that it breaks things, I'm assuming that it is unintentional.
> 
> Fixes: 2abb7cdc0d ("udp: Add support for doing checksum unnecessary conversion")
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> ---
>  net/ipv4/udp_offload.c | 2 +-
>  net/ipv6/udp_offload.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Good catch, thanks !

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html