lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Sep 2014 12:12:25 +0200 From: Johannes Berg <johannes@...solutions.net> To: Sanjeev Sharma <sanjeev_sharma@...tor.com> Cc: dsd@...too.org, kune@...ne-taler.de, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote: > on some architecture spin_is_locked() always return false in > uniprocessor configuration and therefore it would be advise > to replace with lockdep_assert_held(). > > Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@...tor.com> > --- > Changes in v2: > - corrected the typo Now it compiles, but you got the logic wrong. > +++ b/drivers/net/wireless/zd1211rw/zd_mac.c > @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac) > { > flush_workqueue(zd_workqueue); > zd_chip_clear(&mac->chip); > - ZD_ASSERT(!spin_is_locked(&mac->lock)); > + lockdep_assert_held(&mac->lock); > ZD_MEMCLEAR(mac, sizeof(struct zd_mac)); > } Look closely at this again. johannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists